Remove bad openssl includes#2390
Open
yadij wants to merge 5 commits intosquid-cache:masterfrom
Open
Conversation
This header needs to be included through compat.openssl.h for portability fixes.
yadij
added
M-cleared-for-merge
kinkie
previously approved these changes
Mar 17, 2026
rousskov
requested changes
Mar 18, 2026
Contributor
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
This header needs to be included through compat/openssl.h for portability fixes.
AFAICT, there are at least three more headers that are being included directly even though compat/openssl.h provides the corresponding "portability fixes". Please fix all of the violations. Here is the list of all such headers that I could find:
openssl/asn1.hopenssl/bio.hopenssl/ssl.hopenssl/x509.h
rousskov
added
S-waiting-for-author
this include is duplicate of context_storage.h
yadij
added
S-waiting-for-reviewer
Contributor
|
@rousskov I've
done what you suggest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These headers need to be included through
compat/openssl.h for portability fixes.
Also, remove a redundant include.